rebase #141
rebase #141
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the HdmiInput plugin entirely and adds L2 tests for HdmiCecSink. Key changes include:
- Complete removal of HdmiInput plugin files and directories
- Addition of comprehensive L2 test suite for HdmiCecSink (3879 lines)
- Removal of
pluginInterface->AddRef()call in PluginInterfaceBuilder - Updates to build dependencies and test framework documentation
- CMakeLists and test configuration updates to support new test structure
Reviewed Changes
Copilot reviewed 48 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| helpers/PluginInterfaceBuilder.h | Removed AddRef() call for plugin interface |
| Tests/L2Tests/tests/HdmiCecSink_L2Test.cpp | Added comprehensive L2 test suite for HdmiCecSink |
| Tests/L2Tests/tests/test_foo_IN.cpp | Added basic test placeholder |
| Tests/L2Tests/CMakeLists.txt | Updated to C++14 and restructured test builds |
| Tests/L1Tests/tests/test_HdmiCecSink.cpp | Refactored L1 tests with mocking improvements |
| Tests/L1Tests/tests/test_HdmiCecSource.cpp | Removed event handler registration mocks |
| Tests/L1Tests/tests/test_HdcpProfile.cpp | Cleaned up mock dependencies |
| Tests/L1Tests/CMakeLists.txt | Removed HdmiInput tests, updated C++14 standard |
| HdmiInput/* | Complete removal of HdmiInput plugin |
| build_dependencies.sh | Changed entservices-apis branch and added stub files |
| cov_build.sh | Added libdrm include path |
| Tests/README.md | Updated documentation with better formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (pluginInterface) { | ||
| pluginInterface->AddRef(); | ||
| LOGINFO("plugin interface succeed and retry count: %d",count); | ||
| return pluginInterface; | ||
| } |
There was a problem hiding this comment.
Removing the AddRef() call at line 116 (before the removed line) could lead to premature object destruction. When QueryInterfaceByCallsign returns an interface pointer, the reference count is incremented. Previously, an explicit AddRef() was called to maintain an additional reference. Removing this call without corresponding changes to ensure proper lifetime management may cause the interface to be released prematurely when other holders release their references, potentially leading to use-after-free bugs.
| git clone --branch R4.4.1 https://github.com/rdkcentral/Thunder.git | ||
|
|
||
| git clone --branch main https://github.com/rdkcentral/entservices-apis.git | ||
| git clone --branch develop https://github.com/rdkcentral/entservices-apis.git |
There was a problem hiding this comment.
Changing the branch from 'main' to 'develop' for entservices-apis could introduce instability issues as the develop branch may contain untested or unstable code. Consider documenting why this branch change was necessary or reverting to a stable branch/tag for production builds.
|
|
||
| set_target_properties(${MODULE_NAME} PROPERTIES | ||
| CXX_STANDARD 11 | ||
| CXX_STANDARD 14 |
There was a problem hiding this comment.
The C++ standard has been upgraded from C++11 to C++14. Ensure all code in the test suite is compatible with C++14 and that this change aligns with the project's overall C++ standard requirements. If other parts of the codebase still use C++11, this could create inconsistencies.
* RDKEMW-8289 - CEC is not working after an FSR
1.5.1 release 1.5.1
* RDKEMW-9750 HdmiCecSource/Sink issues Reason for change: Remove CEC device when there is a ping exception Test Procedure: Unplug the HDMI cable and check if the removeDevice() is called. Risks: None Priority: P1 * Update HdmiCecSourceImplementation.cpp * Update HdmiCecSourceImplementation.cpp * Update HdmiCecSourceImplementation.cpp --------- Co-authored-by: apatel859 <[email protected]>
1.5.2 release 1.5.2
RDKEMW-9633: Advanced PQ AVOutput
1.5.3 release 1.5.3
RDKEMW-9955 : Fix PQMode index issue in Advance PQParams Implementation
1.5.4 release 1.5.4
No description provided.